Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free memory in an error path in spl-kmem-cache.c #17041

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

vandanarungta
Copy link
Contributor

skc->skc_name also needs to be freed in an error path.

Motivation and Context

Noticed this memory leak while reviewing code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

skc->skc_name also needs to be freed in an error path.

Signed-off-by: Vandana Rungta <[email protected]>
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 11, 2025
@amotin amotin merged commit db62886 into openzfs:master Feb 12, 2025
24 of 25 checks passed
ixhamza pushed a commit to truenas/zfs that referenced this pull request Feb 19, 2025
skc->skc_name also needs to be freed in an error path.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Vandana Rungta <[email protected]>
Closes openzfs#17041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants