icp: Clean up AES-GCM AVX/AVX2 implementation selection #17061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Work in Progress
lowjoel
force-pushed
the
aes-gcm-impl-cleanup
branch
from
96abcf5 to
c4b49c1
Compare
13 tasks
lowjoel
force-pushed
the
aes-gcm-impl-cleanup
branch
2 times, most recently
from
bdc63f6 to
06eefea
Compare
This uses the AVX2 versions of the AESENC and PCLMULQDQ instructions; on Zen 3 this provides an up to 80% performance improvement. Original source: https://github.com/google/boringssl/blob/13840dd094f9e9c1b00a7368aa25e656554221f1/gen/bcm/aes-gcm-avx2-x86_64-linux.S See the original BoringSSL commit at google/boringssl@3b6e1be. Signed-off-by: Joel Low <[email protected]>
- Accept GCM H variable in network endianness (ICP convention) - Fix round count offset in AES_KEY struct (ICP convention) - Use RET macro for kernel code Signed-off-by: Joel Low <[email protected]>
Signed-off-by: Joel Low <[email protected]>
Signed-off-by: Joel Low <[email protected]>
lowjoel
force-pushed
the
aes-gcm-impl-cleanup
branch
from
06eefea to
d0dba00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the implementation selection proposed in #17058. Depends on #17058 being merged (this branch shares common ancestry)
Motivation and Context
#17058 added the AVX2 implementation of AES-GCM from BoringSSL but subtly broke the
cycleimplementation and would not compile on older assemblers which did not understand the AVX2 instructions.Description
Combine the
use_avx/use_avx2flags into an enum, allowing toggling of the different implementations that are available. Also, define different values ofCAN_USE_GCM_ASMto indicate various levels of compiler support.How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.