Skip to content

Commit

Permalink
Improves the README.md.
Browse files Browse the repository at this point in the history
  • Loading branch information
jcchavezs committed Nov 15, 2017
1 parent e137cda commit e026141
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ the correct spot in the tree representing the distributed operation.

### Local Tracing

When tracing local code, just run it inside a $span->
When tracing local code, just run it inside a span

```php
$span = $tracer->newTrace()->setName('encode')->start();
Expand Down Expand Up @@ -94,7 +94,7 @@ keys or details. For example, you might add a tag with your runtime
version.

```php
$span->tag('clnt/finagle.version', '6.36.0');
$span->tag('http.status_code', '200');
```

### RPC tracing
Expand Down Expand Up @@ -310,12 +310,6 @@ Here's an example of AWS propagation:
* `TraceContext` if trace and span IDs were present.
* `SamplingFlags` if no identifiers were present

## Disabling Tracing

If you are in a situation where you need to turn off tracing at runtime,
invoke `$tracing->setNoop(true)`. This will turn any new spans into "noop"
spans, and drop any data until `$tracing->setNoop(false)` is invoked.

## Tests

Tests can be run by
Expand Down

0 comments on commit e026141

Please sign in to comment.