Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify Duration minutes indefinite is 0 #125

Merged
merged 13 commits into from
Aug 21, 2024
Merged

clarify Duration minutes indefinite is 0 #125

merged 13 commits into from
Aug 21, 2024

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier requested a review from a team as a code owner August 17, 2024 13:56
andrewpmartinez
andrewpmartinez requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@andrewpmartinez andrewpmartinez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for a positive test against the ziti repo or generating w/ v0.29.0 (or any other version that doesn't alter every file).

@qrkourier
Copy link
Member Author

Looking for a positive test against the ziti repo or generating w/ v0.29.0 (or any other version that doesn't alter every file).

Tests now pass after re-generating with swagger v0.29.0. Spot checks of unexpected differences reveal only a change from single to multi-line comments. I'm unsure what, precisely, is responsible. I'm curious to know if re-generating on this branch with v0.29.0 on your machine reverts to single-line comments, or is the change sticky?

I'm asking because we wouldn't want dueling implementations to flap between single and multi-line in subsequent commits, but if it's sticky to multi-line, then we could leave it this way and move on.

@qrkourier qrkourier marked this pull request as draft August 21, 2024 14:48
@qrkourier qrkourier marked this pull request as ready for review August 21, 2024 16:09
@qrkourier qrkourier merged commit 299c07f into main Aug 21, 2024
3 checks passed
@qrkourier qrkourier deleted the durationMinutes-indefinite branch August 21, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpmartinez andrewpmartinez andrewpmartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qrkourier @andrewpmartinez