Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use keepalive flags if they are not defined #212

Merged
merged 1 commit into from
Mar 19, 2024
Merged

don't use keepalive flags if they are not defined #212

merged 1 commit into from
Mar 19, 2024

Conversation

scareything
Copy link
Member

@scareything scareything commented Mar 18, 2024

This enables building on Windows with mingw. Functionally similar to #202.

fixes #205

@scareything scareything requested a review from a team as a code owner March 18, 2024 19:05
@ekoby ekoby merged commit 6cd25e3 into main Mar 19, 2024
9 checks passed
@ekoby ekoby deleted the mingw branch March 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build broken after use of setsockopt instead of uv_tcp_keepalive & friends
2 participants