Fix editing and saving of configs on the Config Management page #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dovholuknf
reviewed
Jun 10, 2024
| @@ -812,6 +813,26 @@ export class ZacWrapperService extends ZacWrapperServiceClass { | |||
| }); | |||
| } | |||
|
|
|||
| redefineObject(obj) { | |||
There was a problem hiding this comment.
redefineObject seems like a strange name to me. it feels more like a resetObject to me, but maybe that's my weak js-foo?
dovholuknf
reviewed
Jun 10, 2024
| if (Object.keys(obj[prop]).length==0) { | ||
| delete obj[prop]; | ||
| } | ||
| } |
There was a problem hiding this comment.
there's no 'else' here. feels like a console.log or ... anything ? would be good here?
There was a problem hiding this comment.
are numbers covered? or just left the same?
There was a problem hiding this comment.
are numbers covered? or just left the same?
Should be left the same
dovholuknf
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #360