update ctrl list with new advertised address #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better handle invalid controller responses
dovholuknf
reviewed
Dec 17, 2024
library/ziti.c
Outdated
| model_list_iter it = model_list_iterator(&ztx->config.controllers); | ||
| while(it) { | ||
| char *addr = (char*)model_list_it_element(it); | ||
| if (strcmp(addr, ztx->config.controller_url) == 0) { |
There was a problem hiding this comment.
probably should be case insensitive?
dovholuknf
reviewed
Dec 17, 2024
library/ziti_ctrl.c
Outdated
| const char *k; | ||
| ziti_controller_detail *detail; | ||
| MODEL_MAP_FOREACH(k, detail, &ctrl->endpoints) { | ||
| if (strcmp(k, ctrl->url) == 0) { |
dovholuknf
reviewed
Dec 17, 2024
| if(detail == NULL) { | ||
| detail = alloc_ziti_controller_detail(); | ||
| } | ||
| FREE(detail->name); |
There was a problem hiding this comment.
if detail was NULL previous, you still need to FREE the name? seems like could be in the else?
dovholuknf
reviewed
Dec 17, 2024
| if (resp->resp_content == ctrl_content_text) { | ||
| resp_obj = string_buf_to_string(resp->content_proc, NULL); | ||
| if (resp->body_parse_func) { | ||
| error.code = strdup("INVALID_CONTROLLER_RESPONSE"); |
There was a problem hiding this comment.
i've never noticed this before but i'm surprised the code doesn't come from the corresponding CODE_MAP. seems like they could get out of sync this way.
dovholuknf
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better handle invalid controller responses