Skip to content

Commit

Permalink
Merge pull request #2335 from openziti/docker-console-multi-platform
Browse files Browse the repository at this point in the history 
source platform-specific console image to silence BuildKit warning
  • Loading branch information
@qrkourier
qrkourier authored Sep 24, 2024
2 parents ba59398 + 552653a commit 3b56d73
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions dist/docker-images/ziti-controller/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
ARG ZITI_CLI_TAG="latest"
ARG ZITI_CLI_IMAGE="docker.io/openziti/ziti-cli"

# provide a default value for the platform-neutral static console files
ARG TARGETPLATFORM="linux/amd64"

# dependabot bumps this version based on release to Hub
# only amd64 is available because only static assets are copied, not executables
FROM --platform=linux/amd64 openziti/ziti-console-assets:3.4.7 AS ziti-console
FROM --platform=${TARGETPLATFORM} openziti/ziti-console-assets:3.5.0 AS ziti-console

Check warning on line 10 in dist/docker-images/ziti-controller/Dockerfile

View workflow job for this annotation

GitHub Actions / Publish Release Candidate Docker Images / publish-docker-images

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined ${TARGETPLATFORM} in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

FROM ${ZITI_CLI_IMAGE}:${ZITI_CLI_TAG}

Expand Down

0 comments on commit 3b56d73

Please sign in to comment.