Optimize service add #1727
Merged
Optimize service add #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Inspired by Robert's changes at https://github.com/openziti/ziti/tree/optimize_service_add |
scareything
force-pushed
the
optimize_service_add.smc
branch
from
20205f1
to
76a5f8b
Compare
scareything
force-pushed
the
optimize_service_add.smc
branch
2 times, most recently
from
b4d1226
to
f839734
Compare
scareything
force-pushed
the
optimize_service_add.smc
branch
from
f45b72f
to
39697c6
Compare
plorenz
reviewed
Feb 13, 2024
| @@ -70,6 +70,16 @@ func (self *tunneler) Start(notifyClose <-chan struct{}) error { | |||
| log := pfxlog.Logger() | |||
| log.WithField("mode", self.listenOptions.mode).Info("creating interceptor") | |||
|
|
|||
| resolver, err := dns.NewResolver(self.listenOptions.resolver) | |||
| if err != nil { | |||
| pfxlog.Logger().WithError(err).Error("failed to start DNS resolver") | |||
There was a problem hiding this comment.
There's an issue related to this code: #1513
Do you think you could pop in a quick fix for that here.. just assign a default resolver if the selected resolver initialization fails?
This was
linked to
issues
Feb 14, 2024
plorenz
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP address selection for intercepted hostnames was taking a significant amount of time, especially for large numbers of services (1000's). This PR optimizes IP assignment: