Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get smoketest logs and store in actions #1738

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Get smoketest logs and store in actions #1738

merged 1 commit into from
Feb 9, 2024

Conversation

plorenz
Copy link
Member

@plorenz plorenz commented Feb 9, 2024

No description provided.

@plorenz plorenz requested review from a team as code owners February 9, 2024 03:43
@plorenz plorenz force-pushed the smoketest-logs branch 3 times, most recently from c5a17cd to 409feb2 Compare February 9, 2024 14:20
qrkourier
qrkourier approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine as long as we're not logging secrets.

@plorenz plorenz merged commit 7333893 into release-next Feb 9, 2024
16 checks passed
@plorenz plorenz deleted the smoketest-logs branch February 9, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qrkourier qrkourier qrkourier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plorenz @qrkourier