Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI support for MacOS arm #1748

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

gberl002
Copy link
Contributor

Closes #652

Closes #652

Signed-off-by: gberl002 <[email protected]>
@gberl002 gberl002 requested review from a team as code owners February 13, 2024 15:42
@plorenz
Copy link
Member

plorenz commented Feb 13, 2024

Just a reminder that you have to put the 'fixes #' on the commit, not the PR

@qrkourier
Copy link
Member

Just a reminder that you have to put the 'fixes #' on the commit, not the PR

It'll work on the PR as long as the resolution keyword appears in the description, not a comment, which merely cross-links the GH issue.

@plorenz
Copy link
Member

plorenz commented Feb 13, 2024

Just a reminder that you have to put the 'fixes #' on the commit, not the PR

It'll work on the PR as long as the resolution keyword appears in the description, not a comment, which merely cross-links the GH issue.

It doesn't work with the ziti-ci build-release-notes tool. It would be a nice addition, but it's not currently supported.

Signed-off-by: gberl002 <[email protected]>
@gberl002
Copy link
Contributor Author

Just a reminder that you have to put the 'fixes #' on the commit, not the PR

I did, it put the commit message in as the PR description automatically.

@plorenz
Copy link
Member

plorenz commented Feb 14, 2024

Just a reminder that you have to put the 'fixes #' on the commit, not the PR

I did, it put the commit message in as the PR description automatically.

Ah, I checked the commits, but it was on a new line, and I had to expand to see it. Apologies!

@gberl002 gberl002 merged commit 5127214 into release-next Feb 14, 2024
11 checks passed
@gberl002 gberl002 deleted the isssue-652_m1-ci-support branch February 14, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CLI script M1 Support when github actions allows
3 participants