Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just log error when dns server self-test fails #1767

Merged
merged 1 commit into from
Feb 28, 2024
Merged

just log error when dns server self-test fails #1767

merged 1 commit into from
Feb 28, 2024

Conversation

scareything
Copy link
Member

fixes #1513

@scareything scareything requested review from a team as code owners February 21, 2024 17:21
dovholuknf
dovholuknf approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@dovholuknf dovholuknf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scareything scareything merged commit e5ed982 into release-next Feb 28, 2024
20 checks passed
@scareything scareything deleted the keep.dns.sever.when.selftest.fails branch February 28, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dovholuknf dovholuknf dovholuknf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS service failure should not cause a router restart
2 participants
@scareything @dovholuknf