don't add bind and dial permissions to services for admins #1782
Conversation
scareything
force-pushed
the
fix.1781
branch
from
a0b6efb
to
0e4ef2b
Compare
| } | ||
| } | ||
| // service permissions for admin & non-admin identities will be set according to policies | ||
| service, err = result.manager.ReadForNonAdminIdentityInTx(tx, key, result.identityId) |
There was a problem hiding this comment.
I'm not sure if this is valid when result.identityId == "" ?
| @@ -143,10 +133,14 @@ func (self *EdgeServiceManager) ReadForIdentityInTx(tx *bbolt.Tx, id string, ide | |||
|
|
|||
There was a problem hiding this comment.
Can we merge ReadForNonAdminIdentityInTx into ReadForIdentityInTx, as the 'NonAdmin' name is no longer accurate and the first method is now pretty short?
| } | ||
| } | ||
| // service permissions for admin & non-admin identities will be set according to policies | ||
| service, err = result.manager.ReadForIdentityInTx(tx, key, result.identityId, result.configTypes) |
There was a problem hiding this comment.
☝️ this will now happen when result.identityId == "", and I'm not really sure what that means or if it's ok.
There was a problem hiding this comment.
I'm not sure it can happen, but we could short-circuit it in queryServices. If the identityId is "" we could return the service list result before we run the query.
|
Can you add a note to the changelog as well, please? |
|
unable to rebase due to unsigned commits in release-next. recreating PR as #1919. |
fixes #1781