Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ziti agent snapshot-db match ziti fabric db snapshot. Fixes #2333 #2358

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

plorenz
Copy link
Member

@plorenz plorenz commented Aug 26, 2024

No description provided.

@plorenz plorenz requested review from a team as code owners August 26, 2024 23:59
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the old CLI signature without the path still works and helpfully returns the full path to the auto-generated filename. When specifying the optional output file path, only the specified path is returned (not a problem, just an inconsistency).

@plorenz
Copy link
Member Author

plorenz commented Aug 28, 2024

I confirmed the old CLI signature without the path still works and helpfully returns the full path to the auto-generated filename. When specifying the optional output file path, only the specified path is returned (not a problem, just an inconsistency).

The default path is based on what's specified in the config file for the db. The snapshot code itself doesn't do anything with absolute paths, though maybe it should. I'll save that for a follow-up.

@plorenz plorenz merged commit 466296e into main Aug 28, 2024
32 checks passed
@plorenz plorenz deleted the agent-snapshot-db branch August 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants