Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quickstart release #2434

Merged
merged 4 commits into from
Sep 24, 2024
Merged

fix quickstart release #2434

merged 4 commits into from
Sep 24, 2024

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier changed the base branch from release-next to main September 23, 2024 19:09
@qrkourier qrkourier force-pushed the tidy-and-fix-quickstart-release branch 2 times, most recently from ceeca4c to b8a6d26 Compare September 23, 2024 19:44
@qrkourier qrkourier marked this pull request as ready for review September 23, 2024 19:45
@qrkourier qrkourier requested review from a team as code owners September 23, 2024 19:45
@qrkourier qrkourier force-pushed the tidy-and-fix-quickstart-release branch from b8a6d26 to f26e002 Compare September 23, 2024 22:11
@qrkourier
Copy link
Member Author

qrkourier commented Sep 23, 2024

@dovholuknf I fixed these issues after your review.

  • getZiti() always fails if ZITI_BIN_DIR and ZITI_VERSION_OVERRIDE are both set because _check_env_variable() always fails unless _verify_ziti_version_exists() is run first to set the required values for the override version - solution is to swap the order so _verify_ziti_version_exists() runs first in commit 7d86540
  • some release tarballs have a nested directory "ziti" and some don't leading to inconsistent ziti binary path inside the quickstart container image or wherever getZiti() is run - solution is to handle both is a dir and not a dir in commit f26e002

@dovholuknf
Copy link
Member

some release tarballs have a nested directory "ziti" and some don't

sounds like the ziti archives need to be fixed to me

@qrkourier
Copy link
Member Author

sounds like the ziti archives need to be fixed to me

I should clarify that old release tarballs had the nested directory, and current release tarballs have only the binary, not nested in a directory. The way I said it before may have sounded like it was inconsistently nested in current releases, which isn't the case.

@qrkourier qrkourier merged commit ba59398 into main Sep 24, 2024
37 checks passed
@qrkourier qrkourier deleted the tidy-and-fix-quickstart-release branch September 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants