Assign static layers product specification version from runconfig #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottstanie
reviewed
Aug 16, 2023
src/compass/s1_geocode_slc.py
Outdated
| @@ -247,8 +247,7 @@ def run(cfg: GeoRunConfig): | |||
| t_qa_meta = time.perf_counter() | |||
| with h5py.File(output_hdf5, 'a') as geo_burst_h5: | |||
| root_group = geo_burst_h5[ROOT_PATH] | |||
| identity_to_h5group(root_group, burst, cfg, 'CSLC -S1', | |||
| cfg.product_group.product_specification_version) | |||
| identity_to_h5group(root_group, burst, cfg, 'CSLC -S1') | |||
There was a problem hiding this comment.
Is there supposed to be a space between CSLC and -S1?
There was a problem hiding this comment.
No, I goofed. This should have been fixed by the latest commit
scottstanie
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to assign the product specification version specified in the static layers runconfiguration file to the identification/product_specification_version variable of the CSLC-S1 static layers metadata.
This PR addressed issue #195