New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing data options to produce powerset of possible missing dates #3

Merged

scottstanie merged 3 commits into opera-adt:main from scottstanie:fix-missing-data

Nov 9, 2023

Contributor

scottstanie commented Nov 9, 2023

We were not giving the possibility of excluding some combination of missing dates.
For example, for this frame of data

before we only gave the options

throw away the second-to-last date/column (keeping 21 burst id/rows)
throw away all the blue columns in the bottom 6 rows to keep those 6 burst ids.
Now, we give the 3rd option
throw away all date columns with any blue, keep all burst IDs

scottstanie added 3 commits

November 9, 2023 14:28


          add failing test for missing data options

92f134d


          get small dummy test working, bigger one not

8a3f85c


          dedupe options, make tests pass

f8c9f78

scottstanie merged commit feeddc9 into opera-adt:main

5 checks passed

scottstanie deleted the fix-missing-data branch

November 9, 2023 21:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet