Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate version must be the first item of versions #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clyang82
Copy link

Signed-off-by: Chun Lin Yang [email protected]

apiextensions.k8s.io/v1beta1, there was a version field instead of versions. The version field is deprecated and optional, but if it is not empty, it must match the first item in the versions field.

This PR is to validate this case.

@openshift-ci-robot
Copy link

Hi @clyang82. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2019
@clyang82
Copy link
Author

/assign @kevinrizza

@kevinrizza
Copy link
Member

@clyang82 This pr seems great! Thanks for the contribution. However, fyi we are trying to avoid updating and releasing this project if at all possible given the operator-framework's efforts to deprecate and replace all of our use of app-registry -- so while this pr may merge we may not cut a release for this anytime soon. Is this something you are looking to actively validate?

If you're just looking to contribute to a validation project in the operator-framework, this project aims to replace most of the operator-courier verify functionality once app-registry is deprecated: https://github.com/operator-framework/api/tree/master/pkg/validation

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@kevinrizza
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm Indicates that a PR is ready to be merged. labels Dec 16, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@clyang82
Copy link
Author

clyang82 commented Dec 17, 2019

@kevinrizza Thanks for your information. That is OK. I do not have urgent business requirement to do validation. I just found that the yaml file did not work after pass the courier validation. If you think the PR is ok to merge, then just merge it. Thanks.

I will take a look at https://github.com/operator-framework/api/tree/master/pkg/validation

@kevinrizza
Copy link
Member

@clyang82 Please take a look at these enhancements for more details:

https://github.com/openshift/enhancements/blob/master/enhancements/olm/operator-registry.md
https://github.com/openshift/enhancements/blob/master/enhancements/olm/operator-bundle.md

Essentially we are proposing the use of container image registries as storage to host operator bundles and registry index images.

@openshift-ci-robot
Copy link

@clyang82: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2021
@euld1984
Copy link

euld1984 commented May 7, 2023

The statement "Validate version must be the first item of versions" suggests that when listing out different versions of something, the first item in the list should always be the validated version. This may be important in certain contexts where the order of versions matters, such as in software development where version control is crucial. By placing the validated version first in the list, it helps ensure that it is the most current and reliable version being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants