-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: enable linting and bingo management of the lint tool #1524
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e3d597f
to
2a7814d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1524 +/- ##
==========================================
- Coverage 46.80% 46.80% -0.01%
==========================================
Files 135 135
Lines 15760 15752 -8
==========================================
- Hits 7377 7373 -4
+ Misses 7342 7338 -4
Partials 1041 1041 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jordan Keister <[email protected]>
2a7814d
to
b044ec9
Compare
Signed-off-by: Jordan Keister <[email protected]>
e831f94
to
3b764ff
Compare
b66e003
to
ef05a4a
Compare
Signed-off-by: Jordan <[email protected]>
Discovered that the lint make target doesn't lint anything. It only checks whether go imports are in expected grouping/ordering.
This PR introduces gci support (replacing goimports) as a targeted linter, and implements golang-linter support via a bingo-managed version.
There are discrete commits planned for
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs