Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "controller-tools" update instructions to the v1.25.0 migration guide #6526

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

tiwalter
Copy link
Contributor

@tiwalter tiwalter commented Aug 1, 2023

Fixes #6525.

@openshift-ci openshift-ci bot requested review from anik120 and oceanc80 August 1, 2023 14:55
@jberkhahn jberkhahn added this to the v1.32.0 milestone Aug 7, 2023
Copy link
Contributor

@OchiengEd OchiengEd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The default controller-tools version in operator-sdk v1.25.0 is 0.10.0 so this change will make updated repos match newly created operators.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@jberkhahn
Copy link
Contributor

this looks good, you just have to sign your commit and then we can merge it

@tiwalter
Copy link
Contributor Author

tiwalter commented Aug 9, 2023

I will do it next week. Currently, I'm abroad.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2023

New changes are detected. LGTM label has been removed.

@tiwalter
Copy link
Contributor Author

tiwalter commented Aug 22, 2023

@jberkhahn / @OchiengEd can you please check the failed "sanity / docs" check? It seems to be an issue with the test-docs make target.

@everettraven
Copy link
Contributor

/override sanity/docs

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2023

@everettraven: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • sanity/docs

Only the following failed contexts/checkruns were expected:

  • DCO
  • docs
  • e2e
  • e2e-molecule
  • goreleaser
  • image-scorecard-test-kuttl
  • images
  • integration
  • netlify/operator-sdk/deploy-preview
  • sanity
  • unit

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override sanity/docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@everettraven
Copy link
Contributor

/override docs

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2023

@everettraven: Overrode contexts on behalf of everettraven: docs

In response to this:

/override docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@everettraven everettraven merged commit 15b7c60 into operator-framework:master Oct 5, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "controller-tools" Version Upgrade Instructions in the v1.25.0 Migration Guide
4 participants