-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing "controller-tools" update instructions to the v1.25.0 migration guide #6526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The default controller-tools version in operator-sdk v1.25.0 is 0.10.0
so this change will make updated repos match newly created operators.
this looks good, you just have to sign your commit and then we can merge it |
I will do it next week. Currently, I'm abroad. |
New changes are detected. LGTM label has been removed. |
…ration guide (operator-framework#6525) Signed-off-by: Timo Walter <[email protected]>
@jberkhahn / @OchiengEd can you please check the failed "sanity / docs" check? It seems to be an issue with the |
/override sanity/docs |
@everettraven: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override docs |
@everettraven: Overrode contexts on behalf of everettraven: docs In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
15b7c60
into
operator-framework:master
Fixes #6525.