Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up for Add automated documentation for metrics #6588

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Follow up for Add automated documentation for metrics #6588

merged 1 commit into from
Oct 24, 2023

Conversation

avlitman
Copy link
Contributor

@avlitman avlitman commented Oct 2, 2023 •
edited
Loading

This pr solves #6256.

Follow up for: #6114:

Jira-ticket: https://issues.redhat.com/browse/CNV-26570

  1. Add link to the metrics doc to the main README: decided not to update the README.
  2. Add condition to the log message to be more specific, like "webhook and metrics" where apt, or just "with webhooks".
  3. Update metricsdocs file to use Go template instead of creating a whole bunch of constants.
  4. In discussion: Moving the common generator code to a library. The generator should live in the operator project, but its helpers can still can be moved to a common place: decided not to move at the moment.

@avlitman avlitman temporarily deployed to deploy October 2, 2023 08:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 08:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 08:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 08:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 08:51 — with GitHub Actions Inactive
@avlitman avlitman mentioned this pull request Oct 2, 2023
Closed
@avlitman
Copy link
Contributor Author

avlitman commented Oct 2, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

@avlitman: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:31 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:31 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:31 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:31 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:31 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:33 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:33 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:34 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:34 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:34 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:44 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:44 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:44 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:44 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:45 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 2, 2023 12:47 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 11:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 11:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 11:51 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 11:51 — with GitHub Actions Inactive
@avlitman
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

@avlitman: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avlitman
Follow up for Add automated documentation for metrics
118e6d1 
-Use go template in metricsdocs.go

- Add condition to the log messages
- Update the logs messages to use `and monitoring` only when needed.

Signed-off-by: Aviv Litman <[email protected]>
@avlitman avlitman temporarily deployed to deploy October 23, 2023 12:02 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 12:02 — with GitHub Actions Inactive
everettraven
everettraven approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks for the contribution @avlitman !

Looks like the test failures are related to proxy.golang.org having been down for a bit. I'll monitor and re-run tests as necessary. If any changes are needed based on the failures I'll make sure to update here

@avlitman
Copy link
Contributor Author

Changes look good to me. Thanks for the contribution @avlitman !

Looks like the test failures are related to proxy.golang.org having been down for a bit. I'll monitor and re-run tests as necessary. If any changes are needed based on the failures I'll make sure to update here

Thank you @everettraven!

@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:25 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:25 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:29 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:29 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:29 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:29 — with GitHub Actions Inactive
@avlitman avlitman temporarily deployed to deploy October 23, 2023 16:29 — with GitHub Actions Inactive
@avlitman
Copy link
Contributor Author

@everettraven All tests passed, is there anything else we need in order to merge?

@everettraven everettraven merged commit 034aef6 into operator-framework:master Oct 24, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avlitman @everettraven