Make sure redirect URI does not show as completed prematurely #18068
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
redirect-uri-completed
branch
from
aa070a9 to
f885945
Compare
Since we are now refreshing the entire form from step to step, future steps show as incompleted usually. However, redirect_uri has nothing to do itself, so it previously checked the same thing that the oauth_client checked. This would show it as completed a bit too early. For consistency it now got its own configuration check.
NobodysNightmare
force-pushed
the
redirect-uri-completed
branch
from
f885945 to
a1bc0f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now refreshing the entire form from step to step, future steps show as incompleted usually. However, redirect_uri has nothing to do itself, so it previously checked the same thing that the oauth_client checked. This would show it as completed a bit too early.
For consistency it now got its own configuration check.
Ticket
https://community.openproject.org/projects/cross-application-user-integration-stream/work_packages/61744/activity