feat(idpool): idpool feature for generating id's #400
Conversation
pkg/LinuxGeneralModule/lgm.go
Outdated
| func GenerateRouteTable() uint32 { | ||
| return uint32(rand.Intn(RoutingTableMax-RoutingTableMin+1) + RoutingTableMin) //nolint:gosec | ||
| // RoutingTableRange ModPointer structure of mod ptr definitions | ||
| var RoutingTableRange = struct { |
There was a problem hiding this comment.
if not used in other modules, then the type and members can be lowercased
pkg/LinuxGeneralModule/lgm.go
Outdated
| @@ -363,7 +363,8 @@ func Initialize() { | |||
| brTenant = "br-tenant" | |||
| ipMtu = config.GlobalConfig.LinuxFrr.IPMtu | |||
| ctx = context.Background() | |||
| nlink = utils.NewNetlinkWrapperWithArgs(config.GlobalConfig.Tracer) | |||
| RouteTableGen = utils.IDPoolInit("RTtable", RoutingTableRange.RoutingTableMin, RoutingTableRange.RoutingTableMax) | |||
There was a problem hiding this comment.
if RoutingTableRange is used only to put values here, then why not just use 2 constants routingTableMin and routingTableMax?
| @@ -454,6 +455,7 @@ func setUpBridge(lb *infradb.LogicalBridge) bool { | |||
| //nolint:funlen,gocognit | |||
| func setUpVrf(vrf *infradb.Vrf) (string, bool) { | |||
| IPMtu := fmt.Sprintf("%+v", ipMtu) | |||
| var addKey int | |||
There was a problem hiding this comment.
why we need to declare the variable here, if you zero it on 471?
pkg/LinuxGeneralModule/lgm.go
Outdated
| @@ -465,8 +467,12 @@ func setUpVrf(vrf *infradb.Vrf) (string, bool) { | |||
| vrf.Metadata.RoutingTable = make([]*uint32, 1) | |||
| vrf.Metadata.RoutingTable[0] = new(uint32) | |||
| var routingTable uint32 | |||
| Name := vrf.Name | |||
There was a problem hiding this comment.
please align with Go style guide:
https://google.github.io/styleguide/go/decisions.html
pkg/LinuxGeneralModule/lgm.go
Outdated
| for { | ||
| routingTable = GenerateRouteTable() | ||
| // var key interface{} |
There was a problem hiding this comment.
if code is not sued, it can be removed
pkg/utils/Idpool.go
Outdated
| } | ||
|
|
||
| // ReleaseID get the reference id | ||
| func (ip *IDPool) ReleaseID(key interface{}, ref interface{}) (uint32, uint32) { |
There was a problem hiding this comment.
I do not see that ReleaseID is used anywhere
There was a problem hiding this comment.
its used in vendor plugin code dcgw.go for releasing the ecmp and trie id's
pkg/utils/Idpool.go
Outdated
|
|
||
| // IDPool structure | ||
| /* Helper class for uniquely assigning IDs from a specified integer set (e.g. a | ||
| # range) to keys. IDs are assigned (or read) with get_id(key) and returned back |
There was a problem hiding this comment.
there is no get_id(key) function
pkg/utils/Idpool.go
Outdated
| // IDPool structure | ||
| /* Helper class for uniquely assigning IDs from a specified integer set (e.g. a | ||
| # range) to keys. IDs are assigned (or read) with get_id(key) and returned back | ||
| # into the pool with release_id(key). The IDPool remembers a once-assigned ID |
There was a problem hiding this comment.
there is no release_id(key) function
pkg/utils/Idpool.go
Outdated
| _unusedIDs []uint32 // Yet unused IDs in pool Available ids | ||
| _idsInUse map[interface{}]uint32 // Mapping key: id for currently assigned ids | ||
| _idsForReuse map[interface{}]uint32 // Mapping key: id for previously assigned ids | ||
| _refs map[uint32][]interface{} |
There was a problem hiding this comment.
refs sounds like a counter tracking how many times we requested the same id, no?
There was a problem hiding this comment.
correct, its reference to the same id
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
2 times, most recently
from
790e754
to
eb45583
Compare
Signed-off-by: Venkatesh, Vemula <[email protected]> Signed-off-by: Atul Patel <[email protected]> Signed-off-by: Vemula Venkatesh <[email protected]>
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
eb45583
to
45ace4d
Compare
idpool feature for generating id's for mod pointer, routing table id , trie pointer.