Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): adjust to changed states in nvme api #699

Merged
merged 2 commits into from
Oct 11, 2023
Merged

refactor(frontend): adjust to changed states in nvme api #699

merged 2 commits into from
Oct 11, 2023

Conversation

artek-koltun
Copy link
Contributor

@glimchb
Copy link
Member

glimchb commented Oct 10, 2023 •
edited
Loading

opiproject/opi-api#383 merged, please update the PR

Also please don't forget:

@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Oct 10, 2023
@artek-koltun artek-koltun force-pushed the refactor-frontend-namespace-states branch from 1e82aaa to 1d2247d Compare October 11, 2023 05:56
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #699 (1d2247d) into main (24f5992) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   75.25%   75.31%   +0.06%     
==========================================
  Files          40       40              
  Lines        3613     3622       +9     
==========================================
+ Hits         2719     2728       +9     
  Misses        812      812              
  Partials       82       82
Files Coverage Δ
pkg/frontend/nvme_namespace.go 93.36% <100.00%> (+0.29%) ⬆️

@artek-koltun artek-koltun marked this pull request as ready for review October 11, 2023 06:05
@artek-koltun artek-koltun requested a review from a team as a code owner October 11, 2023 06:05
@artek-koltun
Copy link
Contributor Author

opiproject/opi-api#383 merged, please update the PR

Also please don't forget:

* [refactor(frontend): adjust to changed states in nvme api opi-marvell-bridge#449](https://github.com/opiproject/opi-marvell-bridge/pull/449)

* [refactor(frontend): adjust to changed states in nvme api opi-nvidia-bridge#446](https://github.com/opiproject/opi-nvidia-bridge/pull/446)

* [refactor(frontend): adjust to changed states in nvme api opi-xsight-bridge#136](https://github.com/opiproject/opi-xsight-bridge/pull/136)

* https://github.com/opiproject/opi-amd-bridge/blob/9788b5f1421d0ed18cc10cf286c897bc4a34f08c/pkg/frontend/nvme_namespace.go#L64

I will update those PRs when this one is approved and merged

@glimchb glimchb merged commit cc62957 into opiproject:main Oct 11, 2023
18 checks passed
@artek-koltun artek-koltun deleted the refactor-frontend-namespace-states branch November 17, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb