test: test nvme entities over HTTP #878
Merged
+96
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 40 40
Lines 3693 3693
=======================================
Hits 2766 2766
Misses 839 839
Partials 88 88 ☔ View full report in Codecov by Sentry. |
artek-koltun
force-pushed
the
run-http-gateway
branch
4 times, most recently
from
0677f30
to
6d14ea9
Compare
glimchb
reviewed
Jan 31, 2024
artek-koltun
force-pushed
the
run-http-gateway
branch
5 times, most recently
from
a00b051
to
87a21f9
Compare
artek-koltun
changed the title
glimchb
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
lgtm once CI failure 500 is fixed
curl: (22) The requested URL returned error: 500
from https://github.com/opiproject/opi-spdk-bridge/actions/runs/7740869173/job/21106738684?pr=878
This is fixed in those PRs Also, I am thinking to move the tests from the script file into docker-compose |
artek-koltun
force-pushed
the
run-http-gateway
branch
from
1181c68
to
6cb6787
Compare
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
|
Merging as is. Let's discuss how to organize http tests in Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.