Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4202: Add support for parsing HasIntegerPartEqualTo rule type. #5610

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix #4202: Add support for parsing HasIntegerPartEqualTo rule type. #5610

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
685e1dd
Add support for parsing HasIntegerPartEqualTo rule type.
TanishMoral11 Dec 20, 2024
c9261a8
Merge branch 'develop' into fix/fraction-has-integer-part-equal-parsing
TanishMoral11 Dec 22, 2024
fbc6706
Merge branch 'develop' into fix/fraction-has-integer-part-equal-parsing
TanishMoral11 Dec 30, 2024
0f9e1ef
Merge branch 'develop' into fix/fraction-has-integer-part-equal-parsing
adhiamboperes Jan 17, 2025
c3a5c53
Added Test
TanishMoral11 Jan 25, 2025
f1e27ae
Resolved Klint
TanishMoral11 Jan 25, 2025
379ea35
Merge branch 'fix/fraction-has-integer-part-equal-parsing' of https:/…
TanishMoral11 Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion domain/src/main/assets/test_exp_id_2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,14 @@
"denominator": 2
}
}
}],
},
{
"rule_type": "HasIntegerPartEqualTo",
"inputs": {
"x": 1
}
}
],
"outcome": {
"dest": "MultipleChoice",
"feedback": {
Expand Down
4 changes: 4 additions & 0 deletions domain/src/main/java/org/oppia/android/domain/util/StateRetriever.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@ class StateRetriever @Inject constructor() {
InteractionObject.newBuilder()
.setNonNegativeInt(inputJson.getInt(keyName))
.build()
"HasIntegerPartEqualTo" ->
InteractionObject.newBuilder()
.setSignedInt(inputJson.getInt(keyName))
.build()
else ->
InteractionObject.newBuilder()
.setFraction(parseFraction(inputJson.getJSONObject(keyName)))
Expand Down
Loading