Updating screenshots for 1.2 before release to see the coverage #5878
+570
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeArchiTek
added
the
type/documentation
|
Lots of great changes 👍🏼 |
BeArchiTek
changed the title
…ot-1-2' into bkr-udpate-screenshot-1-2
BaptisteGi
approved these changes
Mar 5, 2025
| @@ -208,7 +249,7 @@ mutation { | |||
|
|
|||
| In the mutation we passed additional data to the allocated resource, in this case we passed a description attribute. This description attribute will be set on the IP address that was allocated. You can do this for any other attribute and relationship for the destination address type. | |||
|
|
|||
| #### Idempotent allocation of an IP address | |||
| :::success Idempotent allocation of an IP address | |||
There was a problem hiding this comment.
Title has been replaced by success box?
There was a problem hiding this comment.
yes, a title of level 4 was not present in the index. The success box makes it more visual.
| mutation { | ||
| IpamVLANCreate(data:{ | ||
| name: {value: "My vlan"}, | ||
| vlan_id: {from_pool: {id: "My number pool"}} # Here we could either put the ID or HFID |
There was a problem hiding this comment.
Suggested change
| vlan_id: {from_pool: {id: "My number pool"}} # Here we could either put the ID or HFID | |
| vlan_id: {from_pool: {id: "My VLAN ID Pool"}} # Here we could either put the ID or HFID |
Beyond that I'm not sure anymore if it shouldn't be something like {hfid:["My VLAN ID Pool"]}, to be tested I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.