Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Users Account and Users Groups #11

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Add Users Account and Users Groups #11

merged 6 commits into from
Nov 13, 2024

Conversation

BeArchiTek
Copy link
Contributor

No description provided.

@BeArchiTek BeArchiTek requested a review from a team October 2, 2024 19:08
@BeArchiTek BeArchiTek self-assigned this Oct 2, 2024
@BeArchiTek BeArchiTek added the type: enhancement New feature or request label Oct 2, 2024
@wvandeun
Copy link
Contributor

wvandeun commented Oct 3, 2024

What's the idea around these and how does it correlate to the "CoreAccount" model and the new permissions/RBAC?

@BeArchiTek
Copy link
Contributor Author

This schema is to be able to manage user on network device (cisco, juniper mainly so far)

No correlation with CoreAccount and RBAC.
You may want to add new users on your network device without having them as " users" in Infrahub.

@ogenstad
Copy link

ogenstad commented Oct 3, 2024

Perhaps use the term "credential" instead of user?

@BeArchiTek BeArchiTek changed the title Add User and User Class Add User Credential and User Class Oct 3, 2024
@BeArchiTek BeArchiTek changed the title Add User Credential and User Class Add Users Account and Users Groups Nov 7, 2024
BaptisteGi
BaptisteGi approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@BaptisteGi BaptisteGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can rename some model to highlight that these accounts/users are local to devices and not related to infrahub users

@BeArchiTek BeArchiTek merged commit ab48da7 into main Nov 13, 2024
3 checks passed
@BeArchiTek BeArchiTek deleted the bkr-add-user-class branch November 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaptisteGi BaptisteGi BaptisteGi approved these changes

Assignees

@BeArchiTek BeArchiTek

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BeArchiTek @wvandeun @ogenstad @BaptisteGi