Enhanced circuit and cross connect #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BaptisteGi
commented
Nov 6, 2024
BaptisteGi
commented
- Improved circuit schema, it's now a "collection of endpoints"
- Introduced cross-connect schema
BeArchiTek
approved these changes
Nov 7, 2024
| - name: name | ||
| kind: Text | ||
| description: Name of the circuit endoint, could be a MMR position for instance. | ||
| order_weight: 1000 |
There was a problem hiding this comment.
You have oder_weight only on the name, you may want it on status and description as well
| optional: false | ||
| cardinality: one | ||
| kind: Attribute | ||
| order_weight: 900 |
There was a problem hiding this comment.
I would find it nicer to have the identifier first on the left before the provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.