Skip to content

Commit

Permalink
add JDK 21 test
Browse files Browse the repository at this point in the history
  • Loading branch information
xuwei-k committed Oct 13, 2023
1 parent b36c91e commit e477782
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 1 deletion.
46 changes: 45 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ jobs:
matrix:
os: [ubuntu-latest]
scala: [2.13, 3]
java: [temurin@8]
java: [temurin@8, temurin@21]
project: [rootJS, rootJVM, rootNative]
exclude:
- project: rootJS
java: temurin@21
- project: rootNative
java: temurin@21
runs-on: ${{ matrix.os }}
timeout-minutes: 60
steps:
Expand All @@ -52,6 +57,19 @@ jobs:
if: matrix.java == 'temurin@8' && steps.setup-java-temurin-8.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (temurin@21)
id: setup-java-temurin-21
if: matrix.java == 'temurin@21'
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 21
cache: sbt

- name: sbt update
if: matrix.java == 'temurin@21' && steps.setup-java-temurin-21.outputs.cache-hit == 'false'
run: sbt +update

- name: Check that workflows are up to date
run: sbt githubWorkflowCheck

Expand Down Expand Up @@ -125,6 +143,19 @@ jobs:
if: matrix.java == 'temurin@8' && steps.setup-java-temurin-8.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (temurin@21)
id: setup-java-temurin-21
if: matrix.java == 'temurin@21'
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 21
cache: sbt

- name: sbt update
if: matrix.java == 'temurin@21' && steps.setup-java-temurin-21.outputs.cache-hit == 'false'
run: sbt +update

- name: Download target directories (2.13, rootJS)
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -241,6 +272,19 @@ jobs:
if: matrix.java == 'temurin@8' && steps.setup-java-temurin-8.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (temurin@21)
id: setup-java-temurin-21
if: matrix.java == 'temurin@21'
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 21
cache: sbt

- name: sbt update
if: matrix.java == 'temurin@21' && steps.setup-java-temurin-21.outputs.cache-hit == 'false'
run: sbt +update

- name: Submit Dependencies
uses: scalacenter/sbt-dependency-submission@v2
with:
Expand Down
1 change: 1 addition & 0 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ inThisBuild(
name = Some("Run documentation"),
cond = Some(s"matrix.scala == '${scala2Version}' && matrix.project == 'rootJVM'")
),
githubWorkflowJavaVersions += JavaSpec.temurin("21"),
githubWorkflowPublishPostamble += WorkflowStep.Sbt(
List("docs/docusaurusPublishGhpages"),
name = Some("Publish website"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ package monocle
import java.net.URL
import org.scalacheck.{Arbitrary, Cogen, Gen}
import cats.Eq
import scala.annotation.nowarn

private[monocle] trait PlatformSpecificTestInstances {
implicit val urlEqual: Eq[URL] = Eq.instance((a, b) => a.toURI() == b.toURI())

@nowarn("msg=constructor URL in class URL is deprecated")
implicit def urlArbitrary: Arbitrary[URL] =
Arbitrary {
val idGen = Gen.nonEmptyListOf(Gen.alphaChar).map(_.mkString)
Expand Down

0 comments on commit e477782

Please sign in to comment.