Expose AxModelManager methods in Service API generators and add new plotting methods
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
The previous implementation was failing for numpy dtypes, as it was assuming the use of native python types. This prevented the generator from being initalized, for example, from an `ExplorationDiagnostics`. This is because the parameters in the diags are read from the serialized json file, and thus always initialized with the numpy dtype name.
AngelFP
changed the title
AxModelManager methods in Service API generators and add new plotting methods
AngelFP
changed the title
AxModelManager methods in Service API generators and add new plotting methodsAxModelManager methods in Service API generators and add new plotting methods
Conflicts: optimas/generators/ax/service/base.py
delaossa
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new plotting methods to
AxModelManager(plot_cross_validationandplot_feature_importance) and makes theAxServiceGenerators(i.e., all Ax generators based on the Service API) inherit fromAxModelManager. This exposes all plotting methods and other utilities of the manager directly at the generator, which is convenient for interactive optimization.plot_contour:plot_cross_validation:plot_slice:plot_feature_importance: