Feature/interface updates #250
Conversation
| from .base import Generator | ||
|
|
||
|
|
||
| class ExternalGenerator(Generator): |
There was a problem hiding this comment.
The reason this wrapper is necessary is that Optimas generators contain a number of variables that are not present in our generators such as varying_parameters etc... (basically everything in the Optimas generator constructors). By wrapping the generator like this, we can allow Optimas functions to make the necessary updates to those data structures (e.g., in ask_trials/tell_trials), while the actual ask/tell() functions only deal with the standard.
As libEnsemble generators do not inherit from Optimas generators, we don't have those, so there has to be some way to give Optimas VaryingParameters etc...
There was a problem hiding this comment.
The only other thing I can think would be to pass VaryingParameters etc.. into Optimas as a separate config, alongside the standard (or libE) generator. And Optimas could create the wrapper internally, maybe. I'm not sure thats preferable though.
I guess for Optimas to be fully supportive of the generator standard, the constructors still need updating. So Variables is converted to VaryingParameters, but there is still a lot of extra options for Optimas gens (e.g custom_trial_parameters or allow_fixed_parameters)
No description provided.