Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9780] Return Latest Experiment When Duplicate Keys in Config #430

Merged
merged 7 commits into from
Dec 6, 2023
Merged

[FSSDK-9780] Return Latest Experiment When Duplicate Keys in Config #430

merged 7 commits into from
Dec 6, 2023

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Dec 5, 2023

Summary

  • As a developer, I want to avoid non-deterministic return values in optimizely_get_config method so that I can anticipate the return values in my application logic.
  • The problem: we have flag 1 and flag 2. We have experiment rule A with id 123 and experiment rule A with id 456 (same rule key). Flag 1 has the first experiment rule A, flag 2 has the second experiment rule A. Has a rule with the same experiment key.
    We want to avoid that, so we provide a check and a warning log.

Test plan

  • write unit tests

Issues

@Mat001 Mat001 requested a review from a team as a code owner December 5, 2023 17:53
jaeopt
jaeopt approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewleap-optimizely
andrewleap-optimizely approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mat001 Mat001 merged commit f778989 into master Dec 6, 2023
16 checks passed
@Mat001 Mat001 deleted the mpirnovar-duplicate-exper-key branch December 6, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mat001 @jaeopt @andrewleap-optimizely