Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpirnovar update error #433

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Mpirnovar update error #433

merged 3 commits into from
Mar 12, 2024

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Mar 11, 2024

Summary

  • Update error log message, make it more accurate

Test plan

Issues

@Mat001 Mat001 self-assigned this Mar 11, 2024
@Mat001 Mat001 requested a review from a team as a code owner March 11, 2024 18:27
@Mat001
Copy link
Contributor Author

Mat001 commented Mar 11, 2024

@andrewleap-optimizely (cc @pvcraven ) Any idea why with "self.assertRaises(OverflowError):" would not catch the Overflow error. But logs when Overflow exception occurs do show. It's all in the _run() function in config_manager().

I trigger Overflow error by passing a very large (overflowing) int to the update_interval for polling.

What confuses me is that the logs from that try block in the _run() funciton do show, but the Error is not raised.
The assumption is that I mock the right thing.

Here I mock fetch_datafile get request that is inside PollingConfigManager:

project_config_manager = config_manager.PollingConfigManager(sdk_key=sdk_key,
logger=mock_logger,
update_interval=12345678912345)

However the error happens in the _run() function that is part of fetch_datafile(). Maybe error doesn't bubble up?

@Mat001 Mat001 merged commit 2f00b4d into master Mar 12, 2024
24 checks passed
@Mat001 Mat001 deleted the mpirnovar-update-error branch March 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants