Use TanStack Table instead of self-implemented DataGrid #846
+495
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisuke-umezawa
changed the title
keisuke-umezawa
force-pushed
the
feature/tanstack-table
branch
2 times, most recently
from
6bec4f1
to
5bb1c08
Compare
keisuke-umezawa
changed the title
keisuke-umezawa
force-pushed
the
feature/tanstack-table
branch
2 times, most recently
from
6db5048
to
c3e2e3b
Compare
keisuke-umezawa
changed the title
keisuke-umezawa
commented
Apr 18, 2024
| getFilteredRowModel: getFilteredRowModel(), | ||
| autoResetPageIndex: false, | ||
| // | ||
| // debugTable: true, |
There was a problem hiding this comment.
[todo] Need to delete.
keisuke-umezawa
changed the title
|
@porink0424 Could you review this PR? |
porink0424
reviewed
Apr 19, 2024
Comment on lines
62
to
66
| function FilterMenu<T>(props: { | ||
| header: Header<T, unknown> | ||
| filterChoices: string[] | ||
| }): React.ReactElement { | ||
| const { header, filterChoices } = props |
There was a problem hiding this comment.
[nits]: How about just receiving arguments with destructing assignment?
function FilterMenu<T>({
header,
filterChoices
}: {
header: Header<T, unknown>
filterChoices: string[]
}): React.ReactElement {
Comment on lines
117
to
121
| function DataGrid<T>(props: { | ||
| data: T[] | ||
| columns: ColumnDef<T>[] | ||
| }): React.ReactElement { | ||
| const { data, columns } = props |
| } | ||
| const TablePaginationActions = (props: TablePaginationActionsProps) => { | ||
| const theme = useTheme() | ||
| const { count, page, rowsPerPage, onPageChange } = props |
| const columns: ColumnDef<Optuna.Attribute, any>[] = [ | ||
| columnHelper.accessor("key", { | ||
| header: "Key", | ||
| footer: (info) => info.column.id, |
There was a problem hiding this comment.
[nits]: Footer is not created in the table, is this prop really necessary or not?
keisuke-umezawa
force-pushed
the
feature/tanstack-table
branch
from
4bd134e
to
9070a8e
Compare
|
@porink0424 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Use TanStack Table instead of self-implemented DataGrid