Separated some UI components into @optuna/react
#851
Conversation
porink0424
changed the title
@optuna/storybook@optuna/react
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 35 35
Lines 2375 2375
=======================================
Hits 1651 1651
Misses 724 724 ☔ View full report in Codecov by Sentry. |
biome.json
Outdated
| @@ -14,6 +14,7 @@ | |||
| ], | |||
| "ignore": [ | |||
| "optuna_dashboard/ts/components/PlotlyColorTemplates.ts", | |||
| "tslib/react/src/components/PlotlyDarkMode.ts", | |||
| "standalone_app/src/PlotlyDarkMode.ts", | |||
There was a problem hiding this comment.
Removed L18 ("standalone_app/src/PlotlyDarkMode.ts"), not L17 ("tslib/react/src/components/PlotlyDarkMode.ts"), thank you for your catch!
standalone_app/package.json
Outdated
| "name": "optuna-dashboard-wasm", | ||
| "private": true, | ||
| "version": "0.0.0", | ||
| "description": "", | ||
| "scripts": { | ||
| "watch": "vite", | ||
| "build:vscode": "webpack" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/plotly.js": "^2.29.2", | ||
| "@types/react": "^18.2.64", | ||
| "@types/react-dom": "^18.2.21", | ||
| "@types/react-router-dom": "^5.3.3", | ||
| "@vitejs/plugin-react": "^4.2.1", | ||
| "compression-webpack-plugin": "^11.1.0", | ||
| "esbuild-loader": "^4.0.3", | ||
| "vite": "^5.1.5", | ||
| "webpack": "^5.90.3", | ||
| "webpack-cli": "^5.1.4" | ||
| }, | ||
| "dependencies": { | ||
| "@emotion/react": "^11.11.3", | ||
| "@emotion/styled": "^11.11.0", | ||
| "@mui/icons-material": "^5.15.12", | ||
| "@mui/lab": "^5.0.0-alpha.167", | ||
| "@mui/material": "^5.15.12", | ||
| "@optuna/react": "../tslib/react", | ||
| "@optuna/storage": "../tslib/storage", | ||
| "module-workers-polyfill": "^0.3.2", | ||
| "notistack": "^3.0.1", | ||
| "optuna": "../rustlib/pkg", | ||
| "plotly.js-dist-min": "^2.30.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-router-dom": "^6.22.3" | ||
| } |
There was a problem hiding this comment.
[question] Should we use a tab for the indentation?
There was a problem hiding this comment.
No specific reason for my change here, so I replaced tab with spaces.
Thanks for your comment.
| @@ -0,0 +1,45 @@ | |||
| import { JournalFileStorage, SQLite3Storage } from "@optuna/storage" | |||
There was a problem hiding this comment.
Could you move this file into tslib/storage or just leaving it in the standalone_app?
There was a problem hiding this comment.
I will leave this here as it is, because loadStorageFromFile function is used in MockStudies,
but certainly this file should not be included in the package.
So I marked this file into exclude in tsconfig.json.
standalone_app/package.json
Outdated
| "optionalDependencies": { | ||
| "@rollup/rollup-linux-x64-gnu": "^4.13.2" | ||
| } |
There was a problem hiding this comment.
Memo:These lines are added to resolve the error due to rollup dependency (module not found error: Error: Cannot find module @rollup/rollup-linux-x64-gnu)
Separated UI components into `@optuna/react` (Continued from #851)
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
@optuna/reactas the first step to make codes common@optuna/reactas common codes:DataGridPlotHistoryTrialTablePlotlyDarkMode