Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution prop to SearchSpaceItem type and move searchSpace to tslib/react #892

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Jun 21, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

@porink0424 porink0424 changed the title Fix/move search space to tslib Add distribution prop to SearchSpaceItem type and move searchSpace to tslib/react Jun 21, 2024
@porink0424 porink0424 marked this pull request as ready for review June 21, 2024 02:32
@porink0424 porink0424 requested a review from c-bata June 21, 2024 02:32
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (0beb2af) to head (747098b).
Report is 71 commits behind head on main.

Current head 747098b differs from pull request most recent head 29c4e73

Please upload reports for the commit 29c4e73 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   69.51%   69.58%   +0.06%     
==========================================
  Files          35       35              
  Lines        2375     2377       +2     
==========================================
+ Hits         1651     1654       +3     
+ Misses        724      723       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit!

tslib/storage/test/journal.test.mjs Show resolved Hide resolved
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after passing CI!

@c-bata c-bata merged commit 0c733bc into optuna:main Jun 26, 2024
16 of 17 checks passed
@porink0424 porink0424 deleted the fix/move-searchSpace-to-tslib branch June 26, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants