Use tslib's PlotIntermediateValue in optuna-dashboard #900
+24
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porink0424
requested changes
Jul 10, 2024
Comment on lines
-84
to
-99
| const isFeasible = trial.constraints.every((c) => c <= 0) | ||
| return { | ||
| x: trial.intermediate_values.map((iv) => iv.step), | ||
| y: trial.intermediate_values.map((iv) => iv.value), | ||
| marker: { maxdisplayed: 10 }, | ||
| mode: "lines+markers", | ||
| type: "scatter", | ||
| name: `trial #${trial.number} ${ | ||
| trial.state === "Running" | ||
| ? "(running)" | ||
| : !isFeasible | ||
| ? "(infeasible)" | ||
| : "" | ||
| }`, | ||
| ...(!isFeasible && { line: { color: "#CCCCCC" } }), | ||
| } |
There was a problem hiding this comment.
The branch by isFeasible is missing on the tslib side, could you add it?
Comment on lines
-64
to
-67
| legend: { | ||
| x: 1.0, | ||
| y: 0.95, | ||
| }, |
There was a problem hiding this comment.
Could you add this property on tslib side?
keisuke-umezawa
commented
Jul 18, 2024
Comment on lines
-83
to
-88
| const values = trial.intermediate_values.filter( | ||
| (iv) => | ||
| iv.value !== Infinity && | ||
| iv.value !== -Infinity && | ||
| !Number.isNaN(iv.value) | ||
| ) |
There was a problem hiding this comment.
I removed those lines because they do not exist in optuna-dashbaord. But, if you feel we should revert them, tell me that, please.
|
@porink0424 I followed your review comments. Could you review it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Use tslib's PlotIntermediateValue in optuna-dashboard