Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distribution property in ParamImportance #905

Conversation

keisuke-umezawa
Copy link
Member

@keisuke-umezawa keisuke-umezawa commented Jul 18, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

Remove distribution property in ParamImportance

@keisuke-umezawa keisuke-umezawa marked this pull request as draft July 18, 2024 08:53
@keisuke-umezawa keisuke-umezawa force-pushed the feature/add-distribution-paramimportance-tslib branch from 05aad94 to 7366550 Compare July 20, 2024 06:03
@keisuke-umezawa keisuke-umezawa marked this pull request as ready for review July 20, 2024 06:03
@keisuke-umezawa keisuke-umezawa changed the title Add distribution property in ParamImportance of tslib Remove distribution property in ParamImportance Jul 20, 2024
@c-bata c-bata self-assigned this Jul 23, 2024
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata merged commit 1845ba3 into optuna:main Jul 23, 2024
9 checks passed
@keisuke-umezawa keisuke-umezawa deleted the feature/add-distribution-paramimportance-tslib branch July 31, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants