Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple dm and IO enhancements #91

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Couple dm and IO enhancements #91

merged 9 commits into from
Dec 6, 2024

Conversation

biger410
Copy link
Member

The following are included in the patch set:

  1. For dm table, adding multipath and snapshort support
  2. New fields adding to blockinfo helpers to troubleshooting io hung with queue freezed
  3. couple helpers to remove redundant code or fix small issues

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 28, 2024
@brenns10 brenns10 added this to the drgn-tools next milestone Jul 22, 2024
@biger410 biger410 requested a review from brenns10 December 5, 2024 18:15
@biger410
dm: ensure debuginfo loaded when show dm table
3937c00 
Fix show_dm_table() failure in interactive mode.

Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
dm: show mapped device name when errors happen
d609e8a 
Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
brenns10
brenns10 requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@brenns10 brenns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed each commit individually. There's two tiny requests, nothing major. Thank you!

drgn_tools/dm.py Outdated Show resolved Hide resolved
drgn_tools/dm.py Show resolved Hide resolved
@biger410
dm: add dm_ro() and dm_size() helpers
661d17e 
This two helpers will be used to tell read/write status and size
for any device mapper devices.

Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
dm: add dm table support for multipath device
afecb1a 
Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
tests_dm: add test for dumpping dm table
4bbd74b 
Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
block: add helper to get devt str
59118b2 
Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
dm: add target support for snapshot and snapshot-merge
af2b273 
Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
block: show request_queue freeze status
d394ed6 
When request_queue is freezed, processes which start issuing io will be
blocked, add two new field to blockinfo dump, "Freeze Depth" will tell
how many queue freezing operations is going on and "Usage Counter"
represents those operations who own one ref count of the queue,
queue freezed succeed only when this counter drops to 0, so none zero
"Freeze Depth" with none zero "Usage Counter" means queue freezeing
operation is blocked by the "Usage Counter", the most common reason
for this is that there is in flight ios, check "Inflight I/Os" field.

Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@biger410
ext4_dirlock: unit of inode blocks is sector
ce51d79 
Orabug: 37361260

Signed-off-by: Junxiao Bi <[email protected]>
@brenns10 brenns10 merged commit 63cb679 into oracle-samples:main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenns10 brenns10 brenns10 approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
drgn-tools next
Development

Successfully merging this pull request may close these issues.
2 participants
@biger410 @brenns10