-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Latest Release for Every Merged Pull Request #543
base: master
Are you sure you want to change the base?
Conversation
@@ -30,7 +30,7 @@ jobs: | |||
- name: "🕸️ Get changed metadata matrix" | |||
id: set-matrix | |||
run: | | |||
LATEST_TAG=$(git tag --list | sort -V | tail -1) | |||
LATEST_TAG=$(git tag --list | grep -v latest | sort -V | tail -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional step skips latest
tag as potential base for next standard release tag name (as we always bump patch version in the version string, we want to do so from the latest standard release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe write that comment in the file?
Why is this needed? Are you sure |
This kind of release can give users multiple benefits. For example:
For the |
If someone wants to you the latest metadata, wouldn't it be better if the consumer, the thing that downloads the metadata, uses this link rather than a latest tag that we need to manage manually: https://github.com/oracle/graalvm-reachability-metadata/archive/refs/heads/master.zip |
So I think having a The question that Fabio raises is whether we actually need to do that, given that there's already something similar provided out of the box by GitHub. The difference is that the content of the zip file is different: a metadata release contains directly, at the root of the zip file, the content of the metadata directory only (the rest of the repository is irrelevant for users). The zip provided by GitHub contains a top level directory named |
I would call it |
git push origin "latest" | ||
- name: "📝 Publish a release" | ||
run: | | ||
gh release create "latest" build/graalvm-reachability-metadata-*.zip --title "Latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing line
LGTM |
What does this PR do?
This PR enables automatic
latest
releases. Whenever a new metadata is merged, we will update currentlatest
tag (delete previous and create a new one) to contain that metadata.To make this work, we must create initial latest tag with the corresponding release. Otherwise attempt to delete previous release will fail.