feat: use database to store and retrieve found repos #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Selwyn-Smith <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
behnazh-w
reviewed
Jun 7, 2023
| if db_man and defaults.getboolean("repofinder.java", "use_database"): | ||
| # Perform database lookup | ||
| query = sqlalchemy.text( | ||
| "SELECT remote_path FROM _repository WHERE namespace = :group and name = :artifact" |
There was a problem hiding this comment.
Instead of raw queries, we should use SQLAlchemy's ORM queries, which performs proper validation.
Signed-off-by: Ben Selwyn-Smith <[email protected]>
|
We've decided to review this PR once the new data model PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the third part of the repo finding extension. Making remote calls to retrieve POMs is a costly operation that should be avoided when possible. By adding found repositories to the Macaron database, it can first be polled before any remote calls are needed.