feat: defaults to plaintext / map languages to be rendered as another #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rjborba
requested review from
faustoq and
g-francesca
and removed request for
faustoq and
g-francesca
g-francesca
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons there are some languages that should be rendered as another. HMTL is one of these examples. It should be rendered as XML. I'm unsure about the reason. There probable be another languages that we should take the same approach, but I do not know them yet.
For now I generated a map for these languages.
Also, if the language is unknown, we're highlighting them as plaintext. This way be can scape tokens like:
<h1>which would be rendered as a h1 tag instead of a code.I've also added the broken cases to the storybook so we can keep an eye on it :)