Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/orm-1499 #23

Merged
merged 17 commits into from
Aug 8, 2024
Merged

Feature/orm-1499 #23

merged 17 commits into from
Aug 8, 2024

Conversation

g-francesca
Copy link
Contributor

@g-francesca g-francesca commented Aug 7, 2024

This PR covers:

  • Initial chat suggestions can be customized via suggestions props and they're displayed in the search panel when
  • Accessibility: fixed issues identified via Lighthouse (color contrast still requires some review), implemented keyboard navigation and trap focus for both modal and sliding panel
  • Searchbox story now uses a configuration preset, so it's easier to switch among available configurations and add/edit new config
  • Searchbox props have been extended with chatbox props to cover chat needs

Ref ORM-1499 ORM-1557 ORM-1578 ORM-1593 ORM-1595

Preview

Copy link

linear bot commented Aug 7, 2024

ORM-1499 Keyboard navigation (for desktop and keyboard users only)

Implement keyboard navigation (esc / arrow down and up)

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-ui-components-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 2:09pm

Copy link

linear bot commented Aug 7, 2024

ORM-1557 Add usage & contributing doc

Add documentation to explain:

  • how to get started and contribute
  • how to use the components

ORM-1578 Suggestions as props

We're currently hardcoding suggestions for orama case. We have to make them dynamic via props so users can set their initial suggestions

ORM-1593 Extend orama-chat props to searchbox

ORM-1595 Show initial suggestions when results is empty

When user has not started to search yet or the search has not produced any results, we will show some initial suggestion (the same as chat panel). On click we open sliding panel with suggestion prefilled

@g-francesca g-francesca merged commit 09e93f0 into main Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants