fix: do not set empty token so anon works for public ecr #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
The TokenAuth object has a None value for token until a login is executed. AWS ECR returns a
400 Bad Request
when presented withAuthorization: Bearer None
while Docker Hub returns a401 Unauthorized
with properwww-authenticate
header.This patch simply skips adding
Authorization: Bearer None
which AWS ECR seems to expect. Docker Hub seems to handle the lack of Authorization header the same as if it gotBearer None
.My testing of this patch follows.