Add streaming push #110
Open
Add streaming push #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviramha
requested review from
thomastaylor312,
bacongobbler and
flavio
as code owners
aviramha
force-pushed
the
add_streaming_push
branch
from
d309988
to
648f32b
Compare
Signed-off-by: Aviram Hassan <[email protected]>
Signed-off-by: Aviram Hassan <[email protected]>
Signed-off-by: Aviram Hassan <[email protected]>
aviramha
force-pushed
the
add_streaming_push
branch
from
648f32b
to
b2f855f
Compare
flavio
reviewed
Feb 2, 2024
| .await | ||
| .expect("failed to blob stream push"); | ||
|
|
||
| assert_eq!(layer_location, format!("http://localhost:{}/v2/hello-wasm/blobs/sha256:6165c4ad43c0803798b6f2e49d6348c915d52c999a5f890846cee77ea65d230b", port)); |
There was a problem hiding this comment.
do not hard code the shasum, but rather use digest defined on line 2507
|
I'm not sure about this PR because when I tested it it took infinite time to run opposed to the "one off" functions. I'll finish the re-auth first. |
|
@aviramha can you rebase this PR against main? Also, @thomastaylor312 and I would like to tag a new release of this crate once this PR gets merged :) |
|
I think it'll take me some time to re-visit, while I tried to use this flow I couldn't manage to get it to work so I fear there needs to be more thinking on the design. |
|
@aviramha no worries, I don't think we're on a hurry to push out a new version of the crate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function -
push_blob_streamlets users pass a stream to the blob upload function in order for it to iterate.The signature is similar to the one of the pull so those could be chained.
Builds upon #109