feat: support downloading from customized url #27
Conversation
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
src/lib/release.ts
Outdated
| if (url && checksum) { | ||
| return { | ||
| checksum: checksum, | ||
| url: url | ||
| } | ||
| } |
There was a problem hiding this comment.
What if url is provided but checksum is not provided? What's the proper error message?
There was a problem hiding this comment.
What will happen when checksum is provided if version is provided but url is not provided?
There was a problem hiding this comment.
What if all of three parameters are provided?
There was a problem hiding this comment.
If all three parameters are provided, version is ignored and url/checksum are used. If one of url and checksum is present while the other is missing, an error is thrown.
src/setup.ts
Outdated
| // sanity check | ||
| if (url && !checksum) { | ||
| throw new Error("user provided url of customized ORAS CLI release but without SHA256 checksum"); | ||
| } |
There was a problem hiding this comment.
Should this check be done in getReleaseInfo?
There was a problem hiding this comment.
moved it into getReleaseInfo
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
| with: | ||
| url: ${{ needs.create-test-variables.outputs.url }} | ||
| checksum: ${{ needs.create-test-variables.outputs.checksum }} | ||
|
|
There was a problem hiding this comment.
Need a test on setup ORAS using checksum without URL
There was a problem hiding this comment.
added a test
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
resolves #24