Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show affordance for closing nav menu on mobile #790

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Show affordance for closing nav menu on mobile #790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caaa919
show affordance for closing nav menu on mobile
elvbom Feb 14, 2025
2f49530
adjust top margin according to code rabbit feedback
elvbom Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions ui/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,17 @@ function Mobile({
onClose={handleMenuToggle}
ModalProps={{
keepMounted: true, // Better open performance on mobile.
BackdropProps: {
style: { backgroundColor: "transparent" },
},
}}
sx={{
display: { xs: "block", sm: "none" },
"& .MuiDrawer-paper": {
boxSizing: "border-box",
width: drawerWidth,
backgroundColor: "base.main",
marginTop: (theme) => `${theme.mixins.toolbar.minHeight}px`,
},
zIndex: (theme) => theme.zIndex.drawer + 1,
}}
Expand All @@ -133,15 +137,6 @@ function Mobile({
flexDirection="column"
alignItems="center"
>
<Box sx={{ my: 2 }}>
<Image
src={wordmark.src}
alt="Orcasound"
width={140}
height={60}
priority={true}
/>
</Box>
<Divider color="base.contrastText" />
<List sx={{ maxWidth: (theme) => theme.breakpoints.values.sm }}>
{navItems.map((item) => (
Expand All @@ -154,7 +149,7 @@ function Mobile({
<ListItemIcon
sx={{
color: "base.contrastText",
displa: "flex",
display: "flex",
justifyContent: "center",
opacity: 0.9,
}}
Expand Down