Fix beacon payload offsets in script #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that when all the test values are zero it's easy to confuse one zero with another. I had copied the offsets here from the readthedocs except there were two flaws: - I copied them verbatim but those also include the header in the offsets whereas `ax.payload` does not. All the values need to have 16 subtracted from them. - Due to a caching issue (see e6583f in oresat-configs) some values had the wrong larger type and so the offsets were off for all later entries. Eventually there should be a beacon.pack()/.unpack() so I don't have to bother with manually setting offsets, but until then this suffices.
ryanpdx
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that when all the test values are zero it's easy to confuse one zero with another. I had copied the offsets here from the readthedocs except there were two flaws:
ax.payloaddoes not. All the values need to have 16 subtracted from them.Eventually there should be a beacon.pack()/.unpack() so I don't have to bother with manually setting offsets, but until then this suffices.