Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python,cmake: update version script to support rc #3979

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

vicentebolea
Copy link
Collaborator

No description provided.

@vicentebolea
Copy link
Collaborator Author

@anagainaru this will fix the error that you are observing in your PR

anagainaru
anagainaru previously approved these changes Jan 2, 2024
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the best to review this so maybe wait for Scott to review (I'll approve in case you are confident in this). I'll rebase my PR once this is merged

@vicentebolea
Copy link
Collaborator Author

Scott is off until thursday, you can merge this and have it reverted if it causes trouble

@vicentebolea vicentebolea self-assigned this Jan 2, 2024
@vicentebolea vicentebolea added this to the v2.10.0 milestone Jan 2, 2024
@anagainaru anagainaru merged commit 9f9248a into ornladios:master Jan 2, 2024
37 checks passed
@vicentebolea vicentebolea deleted the adios2-version-fix branch January 9, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants